[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Fix value stored to gnvs is never read

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )

Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/32903/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32903/2//COMMIT_MSG@7 
PS2, Line 7: soc/intel/apollolake: Fix issue found by Clang Static Analyzer
> Please describe the issue here. […]

Updated. Please let me know whether it is proper description.

https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/32903/2/src/soc/intel/apollolake/chip.c@a421 
PS2, Line 421:
> I think what furquan is saying is that we still need to do the cbmem_add, even if we don't assign it […]

Common code southbridge_inject_dsdt already takes care of gnvs. gnvs=cbmem_find(CBMEM_ID_ACPI_GNVS). If gnvs is null, 
then gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(*gnvs)) is executed. We can remove the redundant code here.