Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37874 )
Change subject: soc/intel/cannonlake: Add VR config for CML
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37874/4/src/soc/intel/cannonlake/ch...
PS4, Line 221: /* CPU PL2/4 Config
: * Performance: Maximum PLs for maximum performance.
: * Baseline: Baseline PLs for balanced performance at lower power. */
pls change the code comment format.
/*
* CPU PL2/4 Config
* Performance: Maximum PLs for maximum performance.
* Baseline: Baseline PLs for balanced performance at lower power.
*/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3922bfad5c21dafc64fb05c7d9343b9835b58752
Gerrit-Change-Number: 37874
Gerrit-PatchSet: 4
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jan 2020 06:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment