Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38619 )
Change subject: mb/google/hatch/: Created puff_diskswap variant ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38619/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38619/2//COMMIT_MSG@7 PS2, Line 7: Created Please use imperative mood present tense: Create
https://review.coreboot.org/c/coreboot/+/38619/2//COMMIT_MSG@9 PS2, Line 9: Created puff_diskswap as a variant of puff Please elaborate on the name *diskswap*.
https://review.coreboot.org/c/coreboot/+/38619/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff_diskswap/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38619/2/src/mainboard/google/hatch/... PS2, Line 3: register "SerialIoDevMode" = "{ Shouldn’t tabs be used for indentation?