Attention is currently required from: Felix Singer, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49201 )
Change subject: mb/google/parrot: Put trailing statement in the next line
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49201/comment/fc15cd2e_268fefc3
PS1, Line 9: Fixes a linter error.
You can also mention this is to comply with the coreboot coding style guidelines, and also improves readability (these busy-waiting while loops can look a lot like an ordinary function call when the semicolon is placed on the same line)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f74f25cb2e3edcdd509abd86d80098241c05741
Gerrit-Change-Number: 49201
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 07 Jan 2021 21:02:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment