build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46567 )
Change subject: soc/intel,mb/*: get rid of legacy pad macros ......................................................................
Patch Set 1:
(34 comments)
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/asuka/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 79: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TOUCHPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/caroline/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 88: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TOUCHPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 99: /* GSPI0_CLK */ PAD_CFG_GPI_SCI(GPP_B16, NONE, DEEP, EDGE_SINGLE, INVERT), /* WLAN WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 170: /* DDPD_HPD2 */ PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SMI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 171: /* DDPE_HPD3 */ PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SCI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/cave/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 84: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TRACKPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 95: /* GSPI0_CLK */ PAD_CFG_GPI_SCI(GPP_B16, NONE, DEEP, EDGE_SINGLE, INVERT), /* WLAN WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 166: /* DDPD_HPD2 */ PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SMI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 167: /* DDPE_HPD3 */ PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SCI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/chell/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 78: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TRACKPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 89: /* GSPI0_CLK */ PAD_CFG_GPI_SCI(GPP_B16, NONE, DEEP, EDGE_SINGLE, INVERT), /* WLAN WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 160: /* DDPD_HPD2 */ PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SMI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 161: /* DDPE_HPD3 */ PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SCI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/glados/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 86: /* GSPI0_CLK */ PAD_CFG_GPI_SCI(GPP_B16, NONE, DEEP, EDGE_SINGLE, INVERT), /* WLAN WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 163: /* DDPD_HPD2 */ PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SMI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 164: /* DDPE_HPD3 */ PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, EDGE_SINGLE, INVERT), /* EC_SCI_L */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... File src/mainboard/google/glados/variants/lars/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/google/glados... PS1, Line 74: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TOUCHPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/variants/rvp8/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/intel/kblrvp/... PS1, Line 97: /* SATAXPCIE_4 */ PAD_CFG_NF(GPP_F1, UP_20K, DEEP,NF1), space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/intel/kunimit... File src/mainboard/intel/kunimitsu/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/intel/kunimit... PS1, Line 82: /* SRCCLKREQ0# */ PAD_CFG_GPI_SCI(GPP_B5, NONE, DEEP, EDGE_SINGLE, INVERT), /* TOUCHPAD WAKE */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/gpio.h:
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 22: /* CLKOUT_LPC0 */ _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 23: /* CLKOUT_LPC1 */ _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 51: /* GPIO */ _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 54: /* GPIO */ _PAD_CFG_STRUCT(GPP_B17, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(SCI) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 55: /* GPIO */ _PAD_CFG_STRUCT(GPP_B18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_IRQ_ROUTE(SCI) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 58: /* GSPI1_MISO */ _PAD_CFG_STRUCT(GPP_B21, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 59: /* GSPI1_MOSI */ _PAD_CFG_STRUCT(GPP_B22, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 60: /* GPIO */ _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 63: /* GPIO */ _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 66: /* GPIO */ _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_IRQ_ROUTE(IOAPIC) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 119: /* GPIO */ _PAD_CFG_STRUCT(GPP_E10, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 120: /* GPIO */ _PAD_CFG_STRUCT(GPP_E11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 128: /* DDPB_CTRLDATA */ _PAD_CFG_STRUCT(GPP_E19, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 130: /* DDPC_CTRLDATA */ _PAD_CFG_STRUCT(GPP_E21, PAD_FUNC(NF1) | PAD_RESET(DEEP), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/46567/1/src/mainboard/razer/blade_s... PS1, Line 132: /* GPIO */ _PAD_CFG_STRUCT(GPP_E23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters