build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67525 )
Change subject: cpu/intel/haswell: Hook up Crystal Well µcode updates ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/9c666544_589be47d PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/25024bf7_e4c07b28 PS1, Line 12: the initial µcode inside the CPU can be quite unstable. Intel CPUs with Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 27126f135dad ("cpu/intel/haswell: add Crystal Well CPU IDs")'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/c2ba8e31_db2a75bb PS1, Line 19: is not meant to be used anymore. Hook up the available µcode updates for Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/5d35e7ec_823c6e4c PS1, Line 20: Crystal Well CPUs. Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/65073cc8_d41484b4 PS1, Line 22: Change-Id: If5264f333e681171a2ca4a68be155ffd40a1043b Possible unwrapped commit description (prefer a maximum 72 chars per line)