From gerrit@coreboot.org Sun Sep 11 16:10:49 2022 From: "build bot (Jenkins) (Code Review)" To: coreboot-gerrit@coreboot.org Subject: [coreboot-gerrit] [S] Change in coreboot[master]: cpu/intel/haswell: Hook up Crystal Well =?utf-8?q?=C2=B5code?= updates Date: Sun, 11 Sep 2022 16:10:45 +0000 Message-ID: In-Reply-To: =?utf-8?q?=3Cgerrit=2E1662912624000=2EIf5264f333e681171a2ca4a68?= =?utf-8?q?be155ffd40a1043b=40review=2Ecoreboot=2Eorg=3E?= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5026466493474872330==" --===============5026466493474872330== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable build bot (Jenkins) has posted comments on this change. ( https://review.core= boot.org/c/coreboot/+/67525 ) Change subject: cpu/intel/haswell: Hook up Crystal Well =C2=B5code updates ...................................................................... Patch Set 1: (5 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/9c666544_589be47d=20 PS1, Line 6:=20 Possible long commit subject (prefer a maximum 65 characters) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/25024bf7_e4c07b28=20 PS1, Line 12: the initial =C2=B5code inside the CPU can be quite unstable. In= tel CPUs with Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'Commit 27126f135dad ("cpu/intel/haswell: add Crystal Well CPU= IDs")' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/c2ba8e31_db2a75bb=20 PS1, Line 19: is not meant to be used anymore. Hook up the available =C2=B5co= de updates for Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/5d35e7ec_823c6e4c=20 PS1, Line 20: Crystal Well CPUs. Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158449): https://review.coreboot.org/c/coreboot/+/67525/comment/65073cc8_d41484b4=20 PS1, Line 22: Change-Id: If5264f333e681171a2ca4a68be155ffd40a1043b Possible unwrapped commit description (prefer a maximum 72 chars per line) --=20 To view, visit https://review.coreboot.org/c/coreboot/+/67525 To unsubscribe, or for help writing mail filters, visit https://review.corebo= ot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5264f333e681171a2ca4a68be155ffd40a1043b Gerrit-Change-Number: 67525 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 11 Sep 2022 16:10:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --===============5026466493474872330== Content-Type: text/html Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.html" MIME-Version: 1.0 PHA+PGEgaHJlZj0iaHR0cHM6Ly9yZXZpZXcuY29yZWJvb3Qub3JnL2MvY29yZWJvb3QvKy82NzUy NSI+VmlldyBDaGFuZ2U8L2E+PC9wPjxwPjUgY29tbWVudHM6PC9wPjx1bCBzdHlsZT0ibGlzdC1z dHlsZTogbm9uZTsgcGFkZGluZzogMDsiPjxsaSBzdHlsZT0ibWFyZ2luOiAwOyBwYWRkaW5nOiAw OyI+PHA+Q29tbWl0IE1lc3NhZ2U6PC9wPjx1bCBzdHlsZT0ibGlzdC1zdHlsZTogbm9uZTsgcGFk ZGluZzogMDsiPjxsaSBzdHlsZT0ibWFyZ2luOiAwOyBwYWRkaW5nOiAwIDAgMCAxNnB4OyI+PHAg c3R5bGU9Im1hcmdpbi1ib3R0b206IDRweDsiPlJvYm90IENvbW1lbnQgZnJvbSA8YSBocmVmPSJo dHRwczovL3FhLmNvcmVib290Lm9yZy9qb2IvY29yZWJvb3QtY2hlY2twYXRjaC8xNTg0NDkvIj5j aGVja3BhdGNoPC9hPiAocnVuIElEIGplbmtpbnMtY29yZWJvb3QtY2hlY2twYXRjaC0xNTg0NDkp OjwvcD48cCBzdHlsZT0ibWFyZ2luLWJvdHRvbTogNHB4OyI+PGEgaHJlZj0iaHR0cHM6Ly9yZXZp ZXcuY29yZWJvb3Qub3JnL2MvY29yZWJvb3QvKy82NzUyNS9jb21tZW50LzljNjY2NTQ0XzU4OWJl NDdkIj5QYXRjaCBTZXQgIzEsIExpbmUgNjo8L2E+IDxjb2RlIHN0eWxlPSJmb250LWZhbWlseTpt b25vc3BhY2UsbW9ub3NwYWNlIj48L2NvZGU+PC9wPjxwIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJl LXdyYXA7IHdvcmQtd3JhcDogYnJlYWstd29yZDsiPlBvc3NpYmxlIGxvbmcgY29tbWl0IHN1Ympl Y3QgKHByZWZlciBhIG1heGltdW0gNjUgY2hhcmFjdGVycyk8L3A+PC9saT48bGkgc3R5bGU9Im1h cmdpbjogMDsgcGFkZGluZzogMCAwIDAgMTZweDsiPjxwIHN0eWxlPSJtYXJnaW4tYm90dG9tOiA0 cHg7Ij5Sb2JvdCBDb21tZW50IGZyb20gPGEgaHJlZj0iaHR0cHM6Ly9xYS5jb3JlYm9vdC5vcmcv am9iL2NvcmVib290LWNoZWNrcGF0Y2gvMTU4NDQ5LyI+Y2hlY2twYXRjaDwvYT4gKHJ1biBJRCBq ZW5raW5zLWNvcmVib290LWNoZWNrcGF0Y2gtMTU4NDQ5KTo8L3A+PHAgc3R5bGU9Im1hcmdpbi1i b3R0b206IDRweDsiPjxhIGhyZWY9Imh0dHBzOi8vcmV2aWV3LmNvcmVib290Lm9yZy9jL2NvcmVi b290LysvNjc1MjUvY29tbWVudC8yNTAyNGJmN19lNGMwN2IyOCI+UGF0Y2ggU2V0ICMxLCBMaW5l IDEyOjwvYT4gPGNvZGUgc3R5bGU9ImZvbnQtZmFtaWx5Om1vbm9zcGFjZSxtb25vc3BhY2UiPnRo ZSBpbml0aWFsIMK1Y29kZSBpbnNpZGUgdGhlIENQVSBjYW4gYmUgcXVpdGUgdW5zdGFibGUuIElu dGVsIENQVXMgd2l0aDwvY29kZT48L3A+PHAgc3R5bGU9IndoaXRlLXNwYWNlOiBwcmUtd3JhcDsg d29yZC13cmFwOiBicmVhay13b3JkOyI+UGxlYXNlIHVzZSBnaXQgY29tbWl0IGRlc2NyaXB0aW9u IHN0eWxlICYjMzk7Y29tbWl0ICZsdDsxMisgY2hhcnMgb2Ygc2hhMSZndDsgKCZxdW90OyZsdDt0 aXRsZSBsaW5lJmd0OyZxdW90OykmIzM5OyAtIGllOiAmIzM5O0NvbW1pdCAyNzEyNmYxMzVkYWQg KCZxdW90O2NwdS9pbnRlbC9oYXN3ZWxsOiBhZGQgQ3J5c3RhbCBXZWxsIENQVSBJRHMmcXVvdDsp JiMzOTs8L3A+PC9saT48bGkgc3R5bGU9Im1hcmdpbjogMDsgcGFkZGluZzogMCAwIDAgMTZweDsi PjxwIHN0eWxlPSJtYXJnaW4tYm90dG9tOiA0cHg7Ij5Sb2JvdCBDb21tZW50IGZyb20gPGEgaHJl Zj0iaHR0cHM6Ly9xYS5jb3JlYm9vdC5vcmcvam9iL2NvcmVib290LWNoZWNrcGF0Y2gvMTU4NDQ5 LyI+Y2hlY2twYXRjaDwvYT4gKHJ1biBJRCBqZW5raW5zLWNvcmVib290LWNoZWNrcGF0Y2gtMTU4 NDQ5KTo8L3A+PHAgc3R5bGU9Im1hcmdpbi1ib3R0b206IDRweDsiPjxhIGhyZWY9Imh0dHBzOi8v cmV2aWV3LmNvcmVib290Lm9yZy9jL2NvcmVib290LysvNjc1MjUvY29tbWVudC9jMmJhOGUzMV9k YjJhNzViYiI+UGF0Y2ggU2V0ICMxLCBMaW5lIDE5OjwvYT4gPGNvZGUgc3R5bGU9ImZvbnQtZmFt aWx5Om1vbm9zcGFjZSxtb25vc3BhY2UiPmlzIG5vdCBtZWFudCB0byBiZSB1c2VkIGFueW1vcmUu IEhvb2sgdXAgdGhlIGF2YWlsYWJsZSDCtWNvZGUgdXBkYXRlcyBmb3I8L2NvZGU+PC9wPjxwIHN0 eWxlPSJ3aGl0ZS1zcGFjZTogcHJlLXdyYXA7IHdvcmQtd3JhcDogYnJlYWstd29yZDsiPlBvc3Np YmxlIHVud3JhcHBlZCBjb21taXQgZGVzY3JpcHRpb24gKHByZWZlciBhIG1heGltdW0gNzIgY2hh cnMgcGVyIGxpbmUpPC9wPjwvbGk+PGxpIHN0eWxlPSJtYXJnaW46IDA7IHBhZGRpbmc6IDAgMCAw IDE2cHg7Ij48cCBzdHlsZT0ibWFyZ2luLWJvdHRvbTogNHB4OyI+Um9ib3QgQ29tbWVudCBmcm9t IDxhIGhyZWY9Imh0dHBzOi8vcWEuY29yZWJvb3Qub3JnL2pvYi9jb3JlYm9vdC1jaGVja3BhdGNo LzE1ODQ0OS8iPmNoZWNrcGF0Y2g8L2E+IChydW4gSUQgamVua2lucy1jb3JlYm9vdC1jaGVja3Bh dGNoLTE1ODQ0OSk6PC9wPjxwIHN0eWxlPSJtYXJnaW4tYm90dG9tOiA0cHg7Ij48YSBocmVmPSJo dHRwczovL3Jldmlldy5jb3JlYm9vdC5vcmcvYy9jb3JlYm9vdC8rLzY3NTI1L2NvbW1lbnQvNWQz NWU3ZWNfODIzYzZlNGMiPlBhdGNoIFNldCAjMSwgTGluZSAyMDo8L2E+IDxjb2RlIHN0eWxlPSJm b250LWZhbWlseTptb25vc3BhY2UsbW9ub3NwYWNlIj5DcnlzdGFsIFdlbGwgQ1BVcy48L2NvZGU+ PC9wPjxwIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJlLXdyYXA7IHdvcmQtd3JhcDogYnJlYWstd29y ZDsiPlBvc3NpYmxlIHVud3JhcHBlZCBjb21taXQgZGVzY3JpcHRpb24gKHByZWZlciBhIG1heGlt dW0gNzIgY2hhcnMgcGVyIGxpbmUpPC9wPjwvbGk+PGxpIHN0eWxlPSJtYXJnaW46IDA7IHBhZGRp bmc6IDAgMCAwIDE2cHg7Ij48cCBzdHlsZT0ibWFyZ2luLWJvdHRvbTogNHB4OyI+Um9ib3QgQ29t bWVudCBmcm9tIDxhIGhyZWY9Imh0dHBzOi8vcWEuY29yZWJvb3Qub3JnL2pvYi9jb3JlYm9vdC1j aGVja3BhdGNoLzE1ODQ0OS8iPmNoZWNrcGF0Y2g8L2E+IChydW4gSUQgamVua2lucy1jb3JlYm9v dC1jaGVja3BhdGNoLTE1ODQ0OSk6PC9wPjxwIHN0eWxlPSJtYXJnaW4tYm90dG9tOiA0cHg7Ij48 YSBocmVmPSJodHRwczovL3Jldmlldy5jb3JlYm9vdC5vcmcvYy9jb3JlYm9vdC8rLzY3NTI1L2Nv bW1lbnQvNjUwNzNjYzhfZDQxNDg0YjQiPlBhdGNoIFNldCAjMSwgTGluZSAyMjo8L2E+IDxjb2Rl IHN0eWxlPSJmb250LWZhbWlseTptb25vc3BhY2UsbW9ub3NwYWNlIj5DaGFuZ2UtSWQ6IElmNTI2 NGYzMzNlNjgxMTcxYTJjYTRhNjhiZTE1NWZmZDQwYTEwNDNiPC9jb2RlPjwvcD48cCBzdHlsZT0i d2hpdGUtc3BhY2U6IHByZS13cmFwOyB3b3JkLXdyYXA6IGJyZWFrLXdvcmQ7Ij5Qb3NzaWJsZSB1 bndyYXBwZWQgY29tbWl0IGRlc2NyaXB0aW9uIChwcmVmZXIgYSBtYXhpbXVtIDcyIGNoYXJzIHBl ciBsaW5lKTwvcD48L2xpPjwvdWw+PC9saT48L3VsPjxwPlRvIHZpZXcsIHZpc2l0IDxhIGhyZWY9 Imh0dHBzOi8vcmV2aWV3LmNvcmVib290Lm9yZy9jL2NvcmVib290LysvNjc1MjUiPmNoYW5nZSA2 NzUyNTwvYT4uIFRvIHVuc3Vic2NyaWJlLCBvciBmb3IgaGVscCB3cml0aW5nIG1haWwgZmlsdGVy cywgdmlzaXQgPGEgaHJlZj0iaHR0cHM6Ly9yZXZpZXcuY29yZWJvb3Qub3JnL3NldHRpbmdzIj5z ZXR0aW5nczwvYT4uPC9wPjxkaXYgaXRlbXNjb3BlIGl0ZW10eXBlPSJodHRwOi8vc2NoZW1hLm9y Zy9FbWFpbE1lc3NhZ2UiPjxkaXYgaXRlbXNjb3BlIGl0ZW1wcm9wPSJhY3Rpb24iIGl0ZW10eXBl PSJodHRwOi8vc2NoZW1hLm9yZy9WaWV3QWN0aW9uIj48bGluayBpdGVtcHJvcD0idXJsIiBocmVm PSJodHRwczovL3Jldmlldy5jb3JlYm9vdC5vcmcvYy9jb3JlYm9vdC8rLzY3NTI1Ii8+PG1ldGEg aXRlbXByb3A9Im5hbWUiIGNvbnRlbnQ9IlZpZXcgQ2hhbmdlIi8+PC9kaXY+PC9kaXY+Cgo8ZGl2 IHN0eWxlPSJkaXNwbGF5Om5vbmUiPiBHZXJyaXQtUHJvamVjdDogY29yZWJvb3QgPC9kaXY+Cjxk aXYgc3R5bGU9ImRpc3BsYXk6bm9uZSI+IEdlcnJpdC1CcmFuY2g6IG1hc3RlciA8L2Rpdj4KPGRp diBzdHlsZT0iZGlzcGxheTpub25lIj4gR2Vycml0LUNoYW5nZS1JZDogSWY1MjY0ZjMzM2U2ODEx NzFhMmNhNGE2OGJlMTU1ZmZkNDBhMTA0M2IgPC9kaXY+CjxkaXYgc3R5bGU9ImRpc3BsYXk6bm9u ZSI+IEdlcnJpdC1DaGFuZ2UtTnVtYmVyOiA2NzUyNSA8L2Rpdj4KPGRpdiBzdHlsZT0iZGlzcGxh eTpub25lIj4gR2Vycml0LVBhdGNoU2V0OiAxIDwvZGl2Pgo8ZGl2IHN0eWxlPSJkaXNwbGF5Om5v bmUiPiBHZXJyaXQtT3duZXI6IEFuZ2VsIFBvbnMgJmx0O3RoM2ZhbmJ1c0BnbWFpbC5jb20mZ3Q7 IDwvZGl2Pgo8ZGl2IHN0eWxlPSJkaXNwbGF5Om5vbmUiPiBHZXJyaXQtQ0M6IGJ1aWxkIGJvdCAo SmVua2lucykgJmx0O25vLXJlcGx5QGNvcmVib290Lm9yZyZndDsgPC9kaXY+CjxkaXYgc3R5bGU9 ImRpc3BsYXk6bm9uZSI+IEdlcnJpdC1Db21tZW50LURhdGU6IFN1biwgMTEgU2VwIDIwMjIgMTY6 MTA6NDUgKzAwMDAgPC9kaXY+CjxkaXYgc3R5bGU9ImRpc3BsYXk6bm9uZSI+IEdlcnJpdC1IYXND b21tZW50czogWWVzIDwvZGl2Pgo8ZGl2IHN0eWxlPSJkaXNwbGF5Om5vbmUiPiBHZXJyaXQtSGFz LUxhYmVsczogTm8gPC9kaXY+CjxkaXYgc3R5bGU9ImRpc3BsYXk6bm9uZSI+IEdlcnJpdC1NZXNz YWdlVHlwZTogY29tbWVudCA8L2Rpdj4KCg== --===============5026466493474872330==--