Jonathan Neuschäfer (j.neuschaefer@gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17401
-gerrit
commit f607b8ce2be0d554d304174f4a60613d120fbdf9 Author: Jonathan Neuschäfer j.neuschaefer@gmx.net Date: Sat Nov 12 13:50:17 2016 +0100
soc/marvell/mvmap2315: Fix integer arithmetic
Replace logical with bitwise AND operator.
Change-Id: I712fab61fbbc833fc2b2575948a875e2f07fd5de Reported-by: Coverity (CID 1362808) Signed-off-by: Jonathan Neuschäfer j.neuschaefer@gmx.net --- src/soc/marvell/mvmap2315/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/marvell/mvmap2315/mcu.c b/src/soc/marvell/mvmap2315/mcu.c index c334cda..e634ff8 100644 --- a/src/soc/marvell/mvmap2315/mcu.c +++ b/src/soc/marvell/mvmap2315/mcu.c @@ -31,7 +31,7 @@ static u8 mvmap2315_calc_checksum(const void *data, u32 size) for (i = csum = 0; i < size; i++) csum += bytes[i];
- return (~csum) && 0xFF; + return (~csum) & 0xFF; }
void mcu_irq(void)