Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override ......................................................................
Patch Set 64:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h@45 PS58, Line 45: const
I would prefer keeping it in a separate CL.
Done
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c@147 PS58, Line 147: size_t *len)
Can you please submit an update to checkpatch to allow 96 characters: https://doc.coreboot. […]
https://buganizer.corp.google.com/issues/170217700
https://review.coreboot.org/c/coreboot/+/45459/62/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/62/src/lib/spd_bin.c@196 PS62, Line 196: %s
Looks like use of len somehow got dropped here?
Done