Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34787 )
Change subject: soc/nvidia/tegra210: Fix potential NULL pointer dereference
......................................................................
Patch Set 4: Code-Review-1
I don't think this is correct. Looks like depending on whether the transfer is in or out, only one of the two may be non-NULL at a given time. I think the correct fix would be to make dump_dma_regs() check for NULL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd1412f0956c0a4a75266d1873d5e9848aceee32
Gerrit-Change-Number: 34787
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 18:23:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment