Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/19827 )
Change subject: soc/intel/apollolake: Use CPU common code
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/19827/2/src/soc/intel/apollolake/Makefile.in...
File src/soc/intel/apollolake/Makefile.inc:
PS2, Line 97: CPPFLAGS_common += -I$(src)/soc/intel/apollolake
why we need this
will remove
https://review.coreboot.org/#/c/19827/2/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/cpu.h:
PS2, Line 33: define BASE_CLOCK_MHZ 100
bclk is there at common code
will remove from here
PS2, Line 39: #define APL_BURST_MODE_DISABLE 0x40
already there
will remove from here
--
To view, visit
https://review.coreboot.org/19827
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I529c67cf20253cf819d1c13849300788104b083c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes