Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38032 )
Change subject: mb/google/{beltino,jecht}: Drop SIO configuration lines
......................................................................
Patch Set 1:
so the sio_i2c0_voltage values are never read because 15.1 and 15.2 are "off", but what about sio_acpi_mode: I guess it doesn't matter due to it being set to the default value?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38032
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I252bba6ff1a2547fd0661ad3076470376e95bdd6
Gerrit-Change-Number: 38032
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 02 Jan 2020 14:45:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment