Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: Fix for missing mem_rank info in SMBIOS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31235/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31235/1//COMMIT_MSG@7
PS1, Line 7: Fix for missing mem_rank info in SMBIOS
Please add a prefix (cf. `git log --oneline`), remove one of the two spacse before `mem_rank`, and elaborate what the problem is in the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212215040e4786c258a9c604cc5c2bb62867c842
Gerrit-Change-Number: 31235
Gerrit-PatchSet: 1
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 12:44:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment