build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... PS3, Line 51: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... PS3, Line 51: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... PS3, Line 25: int __weak has_360_sensor_board(void); Using weak declarations can have unintended link defects
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/gpio.c:
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... PS3, Line 38: return gpio_get(SENSOR_DET_360) == 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/3/src/mainboard/google/deltau... PS3, Line 38: return gpio_get(SENSOR_DET_360) == 0; please, no spaces at the start of a line