Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33737 )
Change subject: device/oprom/realmode: Add vbe return status support as per VBE spec 3.0
......................................................................
Patch Set 12: Code-Review+1
(2 comments)
A comment is lagging behind somewhat, otherwise I think this is fine.
https://review.coreboot.org/c/coreboot/+/33737/12/src/device/oprom/realmode/...
File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/33737/12/src/device/oprom/realmode/...
PS12, Line 227: * In x86_asm.S, store EAX into __realmode_ret before jumping into protected
I don't think that explanation is still necessary here since __realmode_ret etc is transparent to the realmode_* user.
https://review.coreboot.org/c/coreboot/+/33737/12/src/device/oprom/realmode/...
PS12, Line 235: Functio
Function
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacd2ce468e038a14424f029df3a0adec3e5fa15c
Gerrit-Change-Number: 33737
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jul 2019 15:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment