EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 663: speeds
This is quite interesting. When I debugging, I am not see this message. I will check this as well.
Done
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/2/payloads/libpayload/drivers... PS2, Line 663: static const char *speeds[] = { "full", "low", "high", "super", "ultra" };
static const char * array should probably be static const char * const
Ack
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usbhub.c:
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 99: if (dev->speed == SUPER_SPEED) : return SUPER_SPEED; : if (dev->speed == SUPER_SPEED_PLUS) : return SUPER_SPEED_PLUS;
This could work thanks. I will modify as well.
Done
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 181: >
SGTM, update the patch soon.
Done
https://review.coreboot.org/c/coreboot/+/35023/1/payloads/libpayload/drivers... PS1, Line 190: >
Same comment as above.
Done