Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32910 )
Change subject: src/arch/x86: Add automatic type41 entry creation ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@55 PS2, Line 55: static const char *smbios_get_name_from_type(u8 device_type) please use const char *get_pci_class_name(struct device *dev) and const char *get_pci_subclass_name(struct device *dev) instead.
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@77 PS2, Line 77: /* Get the device type from the dev struct */ mention type 41
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@1072 PS2, Line 1072: return 0; test for dev->on_mainboard
https://review.coreboot.org/#/c/32910/2/src/arch/x86/smbios.c@1077 PS2, Line 1077: device_type == SMBIOS_DEVICE_TYPE_UNKNOWN) align with (
https://review.coreboot.org/#/c/32910/2/src/include/device/pci_ids.h File src/include/device/pci_ids.h:
https://review.coreboot.org/#/c/32910/2/src/include/device/pci_ids.h@3085 PS2, Line 3085: #define PCI_DEVICE_ID_INTEL_KBL_ID_DT_2 0x5918 unrelated