[coreboot-gerrit] Change in coreboot[master]: Revert "soc/intel/common/{pch,sata}: Remove SATA common code driver"

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43077 )

Change subject: Revert "soc/intel/common/{pch,sata}: Remove SATA common code driver"
......................................................................

Patch Set 4:
> Patch Set 4:
>
> On Fizz chromebox, the reported issue was boot time regression even though SATA worked fine.

the current boot times on Fizz w/upstream master are both absurdly high and so variable (2.7-3.5s) that I can't tell if this revert makes things better, worse, or has no effect at all. Two biggest offenders are 'calling FspMemoryInit' (915ms) and 'device setup done' (1.85s). I'd have to go back and test older builds, but I'm guessing it started sometime between 4.11 and 4.12