Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47387 )
Change subject: drivers/ipmi: Handle the condition when (dev->chip_info == NULL)
......................................................................
Patch Set 4:
I'd just throw an error and call it a day.
How should we "throw an error" in coreboot? Use printk() like this revision? Or use config_of() to "get conf or devtree_die()"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d694b12f6c42961c104fe839d4ee46c0f111197
Gerrit-Change-Number: 47387
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Nov 2020 09:17:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment