Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38383 )
Change subject: intel/i440bx: Resolve long standing raminit TODOs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38383/1/src/northbridge/intel/i440b...
File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/38383/1/src/northbridge/intel/i440b...
PS1, Line 1030: /* Enable normal refresh with the NB. */
“… with the NB.” sounds strange. Just “Enable normal refresh” or “… in the NB”?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62e8b2531f0f297ffb7db440db89ffa65771b7d5
Gerrit-Change-Number: 38383
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jan 2020 11:08:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment