Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39534 )
Change subject: nb/intel/i945/raminit: Simplify if condition
......................................................................
Patch Set 2:
Patch Set 2: -Code-Review
Patch Set 2:
Patch Set 2:
Up to you if you want to merge equivalent wrong code.
As I understand it, the purpose of this change is to land the non-controversial change (that makes the code more easily understandable) while the approach to fix the problem for real can be discussed in your change.
I am not against, I just prefer to fix this code.
Yes, that is my intention.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I041f2740d6991f9b4e6b8f77988b970c028ca512
Gerrit-Change-Number: 39534
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Mar 2020 21:47:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment