Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44229 )
Change subject: soc/amd/picasso: Add speed measurement for spi ......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... PS1, Line 162: for (byte_ptr=(uint8_t *)0xff76c000;byte_ptr<(uint8_t *)0xff76d000;byte_ptr++) { Raul suggested using RWA as a measurement point and to pull in a megabyte at a time as well.
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... PS1, Line 190: for (ptr=(uint32_t *)0xff76d000;ptr<(uint32_t *)0xff76e000;ptr+=4) { ptr math here is likely wrong.