Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41832 )
Change subject: uti/cbfstool: Add option --pow2page ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41832/1/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/41832/1/util/cbfstool/cbfstool.c@17... PS1, Line 174: if (param.force_pow2_pagesize) { Should we check if -P as provided and signal error that both -P and -Q were on the cmdline? Seems to me -P parameters are entirely ignored so we should enforce that.
https://review.coreboot.org/c/coreboot/+/41832/1/util/cbfstool/cbfstool.c@14... PS1, Line 1418: ] s/[ ]/ | /