Attention is currently required from: Raul Rangel, Nico Huber.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49867 )
Change subject: soc/amd/common/block/graphics/graphics: GOP: load VBIOS
......................................................................
Patch Set 14:
(1 comment)
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/49867/comment/6e3d3653_ee907529
PS12, Line 163: copy_vbios
Sorry for continuing to push on this... […]
I like it a lot better than my approach with amd_pci_rom_write_acpi_tables. Thank you for your suggestion!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a6fea9b6cd60c862e15ed2ed539869c0f9bd363
Gerrit-Change-Number: 49867
Gerrit-PatchSet: 14
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 10 Mar 2021 20:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment