Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60726 )
Change subject: soc/intel/cnl: Replace `dt CSE dev state` by `CSE disable` config ......................................................................
soc/intel/cnl: Replace `dt CSE dev state` by `CSE disable` config
Make use of `DISABLE_CSE_AT_PRE_BOOT` config instead dt CSE device state to perform CSE function disable using `heci_disable()`.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I195390b0af0f69bdb085e9ee2a4a8c3e29fd5a67 --- M src/soc/intel/cannonlake/smihandler.c 1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/60726/1
diff --git a/src/soc/intel/cannonlake/smihandler.c b/src/soc/intel/cannonlake/smihandler.c index a287a7b..6a78559 100644 --- a/src/soc/intel/cannonlake/smihandler.c +++ b/src/soc/intel/cannonlake/smihandler.c @@ -16,10 +16,7 @@ */ void smihandler_soc_at_finalize(void) { - if (!CONFIG(HECI_DISABLE_USING_SMM)) - return; - - if (!is_devfn_enabled(PCH_DEVFN_CSE)) + if (CONFIG(DISABLE_CSE_AT_PRE_BOOT) && CONFIG(HECI_DISABLE_USING_SMM)) heci_disable(); }