Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30904 )
Change subject: Revert "vboot: Fix linking error with USE_OPTION_TABLE enabled"
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Thinkpad xx20 series usb_always_on. Replying at the request of Hellsenberg.
Apologies, can confirm that this fixes the broken USB_ALWAYS_ON option on Thinkpad xx20. Confirmed with a T420 and T520.
Please post the commit hash and console log. The question is if the new (non SMM) method is affected, or the old (SMM) method is.
Sorry it took so long, here's a paste of the CBMEM log of both Master and the Revert
Master: https://paste.ee/p/pd1kG
Revert: https://paste.ee/p/9JcpM
I wasn't able prevent the log from being truncated, sorry. Both are around 68KB, so I hope this helps.
Great !
Both logs show that the cmos_layout.bin can be located using the different methods.
Please explain why this change is necessary, as the log(s) doesn't show any issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a13be56d47dc8373d9c6d556505bb2e3674d4a8
Gerrit-Change-Number: 30904
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nathaniel Roach
nroach44@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joseph Samuel Pacheco-Corwin
hammersamatom@gmail.com
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Tue, 29 Jan 2019 16:56:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment