[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I...

[Weimin Wu (Code Review)]

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Zhi7 Li, Karthik Ramasubramanian.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )

Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................

Patch Set 9: Code-Review+1

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/56930/comment/edd2efe0_399444dd 
PS6, Line 7: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
> I have modified this place

Done

File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/56930/comment/f42d255e_e2e4d0c7 
PS7, Line 2: field AUDIO_CODEC_SOURCE 41 43
> Yes, this is the result after confirmation.

Done

https://review.coreboot.org/c/coreboot/+/56930/comment/f62f0731_c57ff907 
PS7, Line 4: 3
> Due to the historical project of HQ, different audio codec ICs are numbered uniformly, so there is s […]

Done

File src/mainboard/google/dedede/variants/sasukette/ramstage.c:

https://review.coreboot.org/c/coreboot/+/56930/comment/099e8397_bb11325f 
PS7, Line 29: 		config->hid =  "RTL5682";
> I have modified this place.

Done

https://review.coreboot.org/c/coreboot/+/56930/comment/27349dd8_ab9dcf88 
PS7, Line 14: 	const struct device_path codec_path[] = {
            : 		{ .type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C4 },
            : 		{ .type = DEVICE_PATH_I2C, .i2c.device = 0x1a }
            : 	};
            : 	const struct device *codec = find_dev_nested_path(pci_root_bus(),
            : 						codec_path, ARRAY_SIZE(codec_path));
            : 	struct drivers_i2c_generic_config *config;
            : 
            : 	if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info)
            : 		return;
            : 
            : 	config = codec->chip_info;
            : 	if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682)))
            : 		config->hid = "10EC5682";
            : 	else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS)))
            : 		config->hid =  "RTL5682";
> I have modified this place, do you think it is appropriate to modify this way?

Done