Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35031 )
Change subject: soc/intel/skylake: Add GPIOs layout for Lewisburg PCH
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/Make...
File src/soc/intel/skylake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/Make...
PS12, Line 87: # FIXME: it is required to add real microcode
: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-5e-03
: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-9e-09
I haven't looked for the microcode on intel resources yet.
I would add the microcode options in a later patch, since the CPUs would use
the microcode.
It would be great. Thank you
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia72c37121fa9616e4ef0ce4acfb36188363c231e
Gerrit-Change-Number: 35031
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Sep 2019 20:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment