Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39850 )
Change subject: [WIP]/mb/google/hatch/vr/puff: Add psys_pmax calculation ......................................................................
Patch Set 4:
(12 comments)
https://review.coreboot.org/c/coreboot/+/39850/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39850/4//COMMIT_MSG@12 PS4, Line 12: dependnets depends
https://review.coreboot.org/c/coreboot/+/39850/4//COMMIT_MSG@11 PS4, Line 11: maybe varies which : dependnets on power ratings … can vary depending on the power ratings
https://review.coreboot.org/c/coreboot/+/39850/4//COMMIT_MSG@12 PS4, Line 12: infomration information
https://review.coreboot.org/c/coreboot/+/39850/4//COMMIT_MSG@14 PS4, Line 14: pcode What is that?
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 87: * Given the hardware design in puff, the serial shunt resistor is 0.01ohm Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 90: 15k What is the unit *k*?
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 91: * Hence, Iinput (Amps) = 9.58A Sorry my ignorance, I am no engineer, but I get 9.6 A.
Iinput = 0.8 * 100 / 50 / 15 * 90 A = 0.8 * 2 * 6 = 9.6 A
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 98: Please use exactly one space and no tab.
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 127: / Please add spaces around the operator.
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 139: gpio_configure_pads. */ Fits on one line in 96 characters.
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 144: && !gpio_get(GPIO_DP_HPD)) { One line? Only copied, so fix in a commit before or in a follow-up?
https://review.coreboot.org/c/coreboot/+/39850/4/src/mainboard/google/hatch/... PS4, Line 149: setup set up