17 Sep
2020
17 Sep
'20
11:44 p.m.
Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45246 )
Change subject: mb/google/volteer/variants/eldrid: Configure DP_HPD as PAD_NC ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45246/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/gpio.c:
https://review.coreboot.org/c/coreboot/+/45246/5/src/mainboard/google/voltee... PS5, Line 22: PAD_NC(GPP_A19, NONE),
I should have added "nit:" as it wouldn't hurt anything, just not needed.
I need remove GPP_A19 or GPP_A20 on the CL?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45246
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31b25be1c9248debf855435c7b688b358e2cd57e
Gerrit-Change-Number: 45246
Gerrit-PatchSet: 5
Gerrit-Owner: Nick Chen nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Kane Chen kane.chen@intel.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Sep 2020 02:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment