Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37719 )
Change subject: biostar/am1ml: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37719/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37719/3//COMMIT_MSG@12 PS3, Line 12:
Remove duplicate sign-off.
Done
https://review.coreboot.org/c/coreboot/+/37719/2/src/mainboard/biostar/am1ml... File src/mainboard/biostar/am1ml/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37719/2/src/mainboard/biostar/am1ml... PS2, Line 85: /* Enable serial decode */
already done in hudson_lpc_decode()
Done
https://review.coreboot.org/c/coreboot/+/37719/2/src/mainboard/biostar/am1ml... PS2, Line 102: ite_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
duplicate of two lines above
You lost ite_kill_watchdog() now completely?