Attention is currently required from: Felix Singer, Maxim Polyakov, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards ......................................................................
Patch Set 10:
(4 comments)
File src/mainboard/asus/sklkbl_h/fadt.c:
https://review.coreboot.org/c/coreboot/+/48648/comment/0beb9a36_f5eb0b44 PS10, Line 8: fadt->preferred_pm_profile = PM_DESKTOP; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/48648/comment/6ed9a716_72259f05 PS10, Line 8: fadt->preferred_pm_profile = PM_DESKTOP; please, no spaces at the start of a line
File src/mainboard/asus/sklkbl_h/variants/h110t/gpio_early.c:
https://review.coreboot.org/c/coreboot/+/48648/comment/4b560c2b_d7452c6c PS10, Line 106: gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/48648/comment/86a878f0_2da2f1fa PS10, Line 106: gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table)); please, no spaces at the start of a line