Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36071 )
Change subject: superio: IT8587E (WIP)
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/36071/2/src/superio/ite/it8587e/sup...
File src/superio/ite/it8587e/superio.c:
https://review.coreboot.org/c/coreboot/+/36071/2/src/superio/ite/it8587e/sup...
PS2, Line 49: Program io0 = 0x70-0x73
the mask for io0 contradicts this, since it if only for a 2 byte io space and not a 4 byte one. […]
I had merely copied from a similar SIO without any clue back then. I'll see what I can figure out. With some help, I managed to set the changes to be marked as WIP now. 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e541daa2b3d48a4f5a0e7b7fa88a2c2f8a1b0c5
Gerrit-Change-Number: 36071
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Dec 2020 05:06:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment
