Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32062 )
Change subject: soc/intel/braswell/smbus: Init SMBus ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32062/2/src/soc/intel/braswell/include/soc/s... File src/soc/intel/braswell/include/soc/smbus.h:
https://review.coreboot.org/#/c/32062/2/src/soc/intel/braswell/include/soc/s... PS2, Line 31: #define HOSTC 0x40 : #define HST_EN (1 << 0) These defines are available in soc\intel\common\block\smbus\smbuslib.h. Any reason for 'redefinition' here?