Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46665 )
Change subject: sb/intel/lynxpoint: Ensure that `dev->chip_info` is not null ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... PS2, Line 144: config_t *config = config_of(dev);
I guess that we didn't call this for PCH-H all the time proves that it's […]
Since this is only called from a single place, I can eliminate the check from here completely and rely on the caller having asserted that the config is non-null.
https://review.coreboot.org/c/coreboot/+/46665/2/src/southbridge/intel/lynxp... PS2, Line 250: if (pch_is_lp()) : pch_gpi_routing(dev); : : /* GPE setup based on device tree configuration */ : enable_all_gpe(config->gpe0_en_1, config->gpe0_en_2, : config->gpe0_en_3, config->gpe0_en_4); : : /* SMI setup based on device tree configuration */ : enable_alt_smi(config->alt_gp_smi_en); Just guard this part.