EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48069 )
Change subject: mb/google/brya: Enable ACPI and add ACPI table
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48069/5/src/mainboard/google/brya/m...
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48069/5/src/mainboard/google/brya/m...
PS5, Line 14:
: static void mainboard_enable(struct device *dev)
: {
: dev->ops->acpi_inject_dsdt = NULL;
: }
May as well drop this function here and add it in 48111?
LGTM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08513ec159b69535f742a1fd70cdec9ec845d414
Gerrit-Change-Number: 48069
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Dec 2020 04:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment