Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39333 )
Change subject: mb/google/volteer: add CNVi ASL entry for dynamic SSDT generation
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39333/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39333/2/src/mainboard/google/voltee...
PS2, Line 229: device pci 14.3 on
: chip drivers/intel/wifi
: register "wake" = "GPE0_PME_B0"
: end
: end # CNVi: WiFi
This is not correct. There is no device that you are adding under chip drivers/intel/wifi.
Fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8baf1c7b770db23f31383bda46ae8d090468560
Gerrit-Change-Number: 39333
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 01:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment