Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c
File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@369
PS6, Line 369: //
I assume that you mean that all comments are to be left justified. […]
You usually use tabs instead of space. Also C style comments are preferred over C++. See https://doc.coreboot.org/coding_style.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 6
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Wed, 19 Jun 2019 06:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Name of user not set #1002358
Gerrit-MessageType: comment