Konrad Adamczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74742 )
Change subject: util/cbmem: Add REG_NEWLINE flag to fix matching pattern
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74742/comment/87a9aa33_11b3c966
PS1, Line 13: REG_NEWLINE
The only real issue is that the `.?` introduced may match a newline
Indeed it is, right. However, the question mark and, as a consequence, syntax `.?` was introduced in POSIX Extended Regular Expression, without `REG_EXTENDED` flag it's not a special character (just a question mark). That's why I've pointed it out explicitly.
Maybe we should change the [^\n]* to .* for consistency now
Good idea, If you're OK with it I can follow up with the patch to replace `[^\n]*` with `.*`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e924349ead0fa7eea8b9ad5161138a4c4946ade
Gerrit-Change-Number: 74742
Gerrit-PatchSet: 2
Gerrit-Owner: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Apr 2023 08:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konrad Adamczyk
konrada@google.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment