Brandon Breitenstein (brandon.breitenstein@intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15068
-gerrit
commit db7be63b1dd29fc0cacf826086ac177c9e394849 Author: Brandon Breitenstein brandon.breitenstein@intel.com Date: Sat Jun 4 00:52:21 2016 +0200
Revert "soc/intel/apollolake: Do not use StackBase FSP-M parameter"
This reverts commit 5ede3d8ccebde6f26c6b24f6458e57d99d5f3957. No longer needed due to FSP being updated, with the 139_40 release, to accept StackBase field
Change-Id: Ic832d8dc4ca87631f5fef80d4d41558d9a72630a Signed-off-by: Brandon Breitenstein brandon.breitenstein@intel.com --- src/soc/intel/apollolake/romstage.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 434d11f..33d61e0 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -240,13 +240,9 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd) * requests. * TODO: add checks to avoid overlap/conflict of CAR usage. */ - - /* fsp does not work with StackBase modified, so use default */ -#if 0 - /* FIXME: remove this once FSP is fixed */ mupd->FspmArchUpd.StackBase = _car_region_end - mupd->FspmArchUpd.StackSize; -#endif + arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {