Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45320 )
Change subject: soc/intel/common/block: Use pci_dev_request_bus_master for BM enabling
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG@9
PS1, Line 9: Replace static sata_final() implementation for BM enabling with generic
: pci_dev_request_bus_master() function.
The purpose of `pci_dev_request_bus_master` is to have a single switch to disable unnecessary bus ma […]
Thanks Angel for suggestion.
https://review.coreboot.org/c/coreboot/+/45320/1//COMMIT_MSG@12
PS1, Line 12: sata
nit: SATA
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd086184fd6fa9c03c806c857f13fad5a9e78a3e
Gerrit-Change-Number: 45320
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Sun, 13 Sep 2020 14:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment