[coreboot-gerrit] Change in coreboot[master]: device: Add pci_s_dev_is_wake_source function

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47260 )

Change subject: device: Add pci_s_dev_is_wake_source function
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47260/1/src/device/pci_ops.c 
File src/device/pci_ops.c:

https://review.coreboot.org/c/coreboot/+/47260/1/src/device/pci_ops.c@82 
PS1, Line 82: pci_s_dev_is_wake_source
> Do we need this separate _s_ call implemented for this function? `pci_dev_is_wake_source()` calls pc […]

A few problems:
1) the check for the dev->type in the original, which you can't do
2)

src/device/pci_ops.c: In function 'pci_dev_is_wake_source':
src/device/pci_ops.c:95:27: error: passing argument 1 of 'pci_s_read_config16' makes integer from pointer without a cast [-Werror=int-conversion]
  pmcs = pci_read_config16(dev, pm_cap + PCI_PM_CTRL);
                           ^~~
In file included from src/arch/x86/include/arch/pci_ops.h:7,
                 from src/include/device/pci_ops.h:9,
                 from src/include/device/pci.h:25,
                 from src/device/pci_ops.c:5:
src/include/device/pci_mmio_cfg.h:116:42: note: expected 'pci_devfn_t' {aka 'unsigned int'} but argument is of type 'const struct device *'
 uint16_t pci_s_read_config16(pci_devfn_t dev, uint16_t reg)

blah blah, which means also the original would have to change to call pci_s_read_config16 and grab the BDF manually, i.e. see the top of pci_ops.h:

```
#if ENV_PCI_SIMPLE_DEVICE

/* Avoid name collisions as different stages have different signature                                                                                                                                              
 * for these functions. The _s_ stands for simple, fundamental IO or                                                                                                                                               
 * MMIO variant.                                                                                                                                                                                                   
 */
#define pci_read_config8 pci_s_read_config8
#define pci_read_config16 pci_s_read_config16
#define pci_read_config32 pci_s_read_config32
#define pci_write_config8 pci_s_write_config8
#define pci_write_config16 pci_s_write_config16
#define pci_write_config32 pci_s_write_config32

```