9 May
2022
9 May
'22
9:39 p.m.
Attention is currently required from: Jacob Garber. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40812 )
Change subject: arch,cpu,lib: Use thin archives instead of partial linking ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/cpu/x86/smm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40812/comment/21d5fc6c_46eb0af4 PS9, Line 50: $(CC_smmstub) -nostdlib -r -o $@ $(COMPILER_RT_FLAGS_smmstub) -Wl,--whole-archive,--start-group $(smmstub-objs) -Wl,--no-whole-archive $(COMPILER_RT_smmstub) -Wl,--end-group Should the stub also created as an archive and linked at the end for consistency?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40812
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I122a4542d1e98d89545897d5177c93ee463d0cdb
Gerrit-Change-Number: 40812
Gerrit-PatchSet: 9
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth gaumless@tutanota.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jacob Garber jgarber1@ualberta.ca
Gerrit-Comment-Date: Mon, 09 May 2022 21:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment