[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add support for generating I2S machine device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42970 )

Change subject: soc/amd/picasso: Add support for generating I2S machine device
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c 
File src/soc/amd/picasso/acp.c:

https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c@8... 
PS1, Line 83: "dmic-gpios"
> This differs from the static asl. […]

ACK.

https://review.coreboot.org/c/coreboot/+/42970/1/src/soc/amd/picasso/acp.c@8... 
PS1, Line 86: 			 0);/* Active low = 0 (Kernel driver does not use active polarity). */
> Please add a space in `;/*`.

Done