Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
......................................................................
Patch Set 6:
But you know what? It doesn't matter. The folder's name is irrelevant when it comes to building and running coreboot on hardware, so any changes to it won't make coreboot better.
...
So, what about stopping the bikeshedding and working on improving the code?
full ACK!
Simple solution: name the new one x11-lga1151v2-series,
then it should become clear.
full ACK again!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573
Gerrit-Change-Number: 35622
Gerrit-PatchSet: 6
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 06 Oct 2019 08:46:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment