[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS power management

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39785 )

Change subject: soc/intel/tigerlake: Configure TCSS power management
......................................................................

Patch Set 15:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39785/14/src/soc/intel/tigerlake/ac... 
File src/soc/intel/tigerlake/acpi/tcss_dma.asl:

https://review.coreboot.org/c/coreboot/+/39785/14/src/soc/intel/tigerlake/ac... 
PS14, Line 44: 0x01
in general there seems to be a mix of 0x1/1 and 0x0/0 throughout.  The 0x seems redundant, so can you make these all just use 0/1?

https://review.coreboot.org/c/coreboot/+/39785/14/src/soc/intel/tigerlake/ac... 
PS14, Line 66: >=
below method uses >0, would be good to be consistent

https://review.coreboot.org/c/coreboot/+/39785/14/src/soc/intel/tigerlake/ac... 
PS14, Line 71: Local0++
should be --?