build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29494 )
Change subject: riscv: add support to select the privilege level of the payload running
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/29494/8/src/arch/riscv/boot.c
File src/arch/riscv/boot.c:
https://review.coreboot.org/#/c/29494/8/src/arch/riscv/boot.c@50
PS8, Line 50: void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/29494/8/src/arch/riscv/payload.c
File src/arch/riscv/payload.c:
https://review.coreboot.org/#/c/29494/8/src/arch/riscv/payload.c@28
PS8, Line 28: uintptr_t status = read_csr(mstatus)
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96961246cd257b63cf167238aa0cf6e65272b951
Gerrit-Change-Number: 29494
Gerrit-PatchSet: 8
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn Chang
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 30 Nov 2018 07:00:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment