Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33275 )
Change subject: [WIP]Makefile.inc: Simplify generating the default fmap ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33275/1/Makefile.inc File Makefile.inc:
https://review.coreboot.org/#/c/33275/1/Makefile.inc@a897 PS1, Line 897: Are you sure that removing the alignment here won't be a problem? fmaptool can't align sections, unfortunately (although that could be added if we want to), and not aligning these to erase blocks would lead to problems.
https://review.coreboot.org/#/c/33275/1/Makefile.inc@912 PS1, Line 912: - $(FMAP_CONSOLE_SIZE) - $(FMAP_MRC_CACHE_SIZE) - $(FMAP_SMMSTORE_SIZE))) Note that you can leave out the size on one entry if the size of the surrounding block is known, so you should be able to get rid of this as well.
https://review.coreboot.org/#/c/33275/1/util/cbfstool/default-x86.fmd File util/cbfstool/default-x86.fmd:
https://review.coreboot.org/#/c/33275/1/util/cbfstool/default-x86.fmd@16 PS1, Line 16: ##CBFS_SIZE## I.e. just leaving this out should automatically fill remaining space.