[coreboot-gerrit] Change in coreboot[master]: soc/amd: Move soc_route_sci to common/blocks/smi/smi_util

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42988 )

Change subject: soc/amd: Move soc_route_sci to common/blocks/smi/smi_util
......................................................................

soc/amd: Move soc_route_sci to common/blocks/smi/smi_util

Change-Id: Ic379723c0bf6e5edf5f3d63cc11b24d0e59b5075
Signed-off-by: Kyösti Mälkki 
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42988
Reviewed-by: Marshall Dawson 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/cezanne/gpio.c
M src/soc/amd/common/block/smi/smi_util.c
M src/soc/amd/picasso/gpio.c
M src/soc/amd/stoneyridge/gpio.c
4 files changed, 5 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Marshall Dawson: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/cezanne/gpio.c b/src/soc/amd/cezanne/gpio.c
index d14f850..6bfdf4d 100644
--- a/src/soc/amd/cezanne/gpio.c
+++ b/src/soc/amd/cezanne/gpio.c
@@ -35,11 +35,6 @@
    { GPIO_129, GEVENT_17 },
 };

-void soc_route_sci(uint8_t event)
-{
-	smi_write8(SMI_SCI_MAP(event), event);
-}
-
 void soc_get_gpio_event_table(const struct soc_amd_event **table, size_t *items)
 {
    *table = gpio_event_table;
diff --git a/src/soc/amd/common/block/smi/smi_util.c b/src/soc/amd/common/block/smi/smi_util.c
index 19a4e32e..dcf0c84 100644
--- a/src/soc/amd/common/block/smi/smi_util.c
+++ b/src/soc/amd/common/block/smi/smi_util.c
@@ -56,6 +56,11 @@
    smi_write32(SMI_REG_SMITRIG0, reg32);
 }

+void soc_route_sci(uint8_t event)
+{
+	smi_write8(SMI_SCI_MAP(event), event);
+}
+
 /**
  * Configure generation of SCIs.
  */
diff --git a/src/soc/amd/picasso/gpio.c b/src/soc/amd/picasso/gpio.c
index 3ad4c5c..3d5dc73 100644
--- a/src/soc/amd/picasso/gpio.c
+++ b/src/soc/amd/picasso/gpio.c
@@ -34,11 +34,6 @@
    { GPIO_129, GEVENT_17 },
 };

-void soc_route_sci(uint8_t event)
-{
-	smi_write8(SMI_SCI_MAP(event), event);
-}
-
 void soc_get_gpio_event_table(const struct soc_amd_event **table, size_t *items)
 {
    *table = gpio_event_table;
diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c
index f1ed202..93264db 100644
--- a/src/soc/amd/stoneyridge/gpio.c
+++ b/src/soc/amd/stoneyridge/gpio.c
@@ -34,11 +34,6 @@
    { GPIO_69, GEVENT_17 },
 };

-void soc_route_sci(uint8_t event)
-{
-	smi_write8(SMI_SCI_MAP(event), event);
-}
-
 void soc_get_gpio_event_table(const struct soc_amd_event **table, size_t *items)
 {
    *table = gpio_event_table;