Attention is currently required from: Eric Lai, Jakub Czapiga, Kane Chen, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................
Patch Set 26:
(1 comment)
Patchset:
PS23:
I will send the log. […]
Log from my system
[DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400
[DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280
[DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa
[DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80
[DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280
[DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa
[DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
[DEBUG] Region[0x7].Tag=0x0 offset=0x0, size=0x0
[DEBUG] Region[0x0].Tag=0x7 offset=0x9b, size=0x400
[DEBUG] Region[0x1].Tag=0x0 offset=0xa00, size=0x280
[DEBUG] Region[0x2].Tag=0x0 offset=0x2bb0, size=0xa
[DEBUG] Region[0x3].Tag=0x0 offset=0x3a00, size=0x80
[DEBUG] Region[0x4].Tag=0x1 offset=0x780, size=0x280
[DEBUG] Region[0x5].Tag=0x1 offset=0x12d8, size=0xa
[DEBUG] Region[0x6].Tag=0x1 offset=0x1600, size=0x6e
make sense to use associated string rather using TAG ids for debug prints ?
I can add this in separate patch. For now, lets merge this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5
Gerrit-Change-Number: 74769
Gerrit-PatchSet: 26
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Thu, 22 Jun 2023 22:48:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment